0.16 wallet and bounty news??

Post Reply
lzknv
Posts: 12
Joined: 28 Aug 2018, 01:00

Re: 0.16 wallet and bounty news??

Post by lzknv » 21 Sep 2018, 23:58

clo1 - I am going to test your code https://github.com/clo-prime/riecoin-0.16 (is this the latest version?)

Let me know if there is something I can help testing or some small independent work items I can help with.

lzknv
Posts: 12
Joined: 28 Aug 2018, 01:00

Re: 0.16 wallet and bounty news??

Post by lzknv » 22 Sep 2018, 16:50

I've got errors when "make", below are few examples:

CXX libriecoin_server_a-blockencodings.o
In file included from ./pow.h:14:0,
from ./chain.h:12,
from ./versionbits.h:8,
from ./validation.h:20,
from blockencodings.cpp:13:
./bignum.h:57:24: error: invalid use of incomplete type ‘BIGNUM {aka struct bignum_st}’
class CBigNum : public BIGNUM
^~~~~~

./bignum.h:68:30: error: cannot convert ‘CBigNum*’ to ‘BIGNUM* {aka bignum_st*}’ for argument ‘1’ to ‘BIGNUM* BN_copy(BIGNUM*, const BIGNUM*)’
if (!BN_copy(this, &b))

./bignum.h: In function ‘bool operator>(const CBigNum&, const CBigNum&)’:
./bignum.h:658:83: error: cannot convert ‘const CBigNum*’ to ‘const BIGNUM* {aka const bignum_st*}’ for argument ‘1’ to ‘int BN_cmp(const BIGNUM*, const BIGNUM*)’
inline bool operator>(const CBigNum& a, const CBigNum& b) { return (BN_cmp(&a, &b) > 0); }
^
Makefile:5523: recipe for target 'libriecoin_server_a-blockencodings.o' failed
make[2]: *** [libriecoin_server_a-blockencodings.o] Error 1
make[2]: Leaving directory '/home/lzknr/riecoin-0.16/src'
Makefile:9463: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/lzknr/riecoin-0.16/src'
Makefile:747: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1


I am using Ubuntu 18.04, code from https://github.com/clo-prime/riecoin-0.16.git

lzknv
Posts: 12
Joined: 28 Aug 2018, 01:00

Re: 0.16 wallet and bounty news??

Post by lzknv » 22 Sep 2018, 17:07

I found this:

https://github.com/zcoinofficial/zcoin/ ... 00e585db3c

Seems to be compatibility with OpenSSL 1.1.0 and could be fixed by ~100 lines of change?

IGJ
Posts: 46
Joined: 21 Aug 2018, 11:43

Re: 0.16 wallet and bounty news??

Post by IGJ » 05 Oct 2018, 12:22

Greetings izknv
Few weeks ago I made something similar as patch for riecoin 16.0 here:

http://download.riecoin-community.com/1 ... 1.patch.gz

PttnMe test it, and at least riecoin 16.0 can be compiled with openssl 1.1 . Unfortunately he told when connecting to main net the wallet do nothing. Most likely I missed something in the patch if you have time can apply the patch and check where could be the problem. Maybe clo1 also can take a look. I will revisit it once get fresh air from work.

Pttn
Posts: 131
Joined: 24 Aug 2018, 13:37

Re: 0.16 wallet and bounty news??

Post by Pttn » 05 Oct 2018, 22:19

Now, we have Riecoin Core 0.16.3. Could you rather do a patch for 0.16.3 instead of 0.16.0? We are now here https://github.com/riecointeam/riecoin

One weird thing also with the current 0.16.3.

If I compile with libssl1.0 on Debian Sid, I get these errors:

Code: Select all

qt/paymentrequestplus.cpp: In member function ‘bool PaymentRequestPlus::getMerchant(X509_STORE*, QString&) const’:
qt/paymentrequestplus.cpp:163:27: error: ‘EVP_MD_CTX_new’ was not declared in this scope
         EVP_MD_CTX *ctx = EVP_MD_CTX_new();
                           ^~~~~~~~~~~~~~
qt/paymentrequestplus.cpp:163:27: note: suggested alternative: ‘EVP_MD_CTX_init’
         EVP_MD_CTX *ctx = EVP_MD_CTX_new();
                           ^~~~~~~~~~~~~~
                           EVP_MD_CTX_init
qt/paymentrequestplus.cpp:178:9: error: ‘EVP_MD_CTX_free’ was not declared in this scope
         EVP_MD_CTX_free(ctx);
         ^~~~~~~~~~~~~~~
qt/paymentrequestplus.cpp:178:9: note: suggested alternative: ‘EVP_MD_CTX_create’
         EVP_MD_CTX_free(ctx);
         ^~~~~~~~~~~~~~~
         EVP_MD_CTX_create
However, the compilation works fine with Debian 9 Stretch.
Last edited by Pttn on 06 Oct 2018, 14:58, edited 1 time in total.
rieMiner - Riecoin solo + pooled miner
Personal Riecoin page (links, download,...)
freebitco.in - earn up to $200 in BTC each hour!

IGJ
Posts: 46
Joined: 21 Aug 2018, 11:43

Re: 0.16 wallet and bounty news??

Post by IGJ » 06 Oct 2018, 12:51

http://download.riecoin-community.com/1 ... 1.patch.gz

This is patch for 16.3, please tell if all is ok when compile with openssl 1.1+ (debian stretch or sid) and openssl 1.0 (debian stretch with downgraded openssl to 1.0 or lower versions of debian 8 or 7).

It is 16.0 patch (did not notice significant changes in bignum.h from 16.0 to 16.3) and added fix for errors PttnMe posted. Right now I am not able to test build qt and done it blindly but should work. If there are more errors in qt/ source when building with openssl 1.1+ please post them I will try fix them too.

Pttn
Posts: 131
Joined: 24 Aug 2018, 13:37

Re: 0.16 wallet and bounty news??

Post by Pttn » 06 Oct 2018, 14:54

I am unable to use your patch.

Code: Select all

git apply riecoind_16.3_openssl_1.1.patch
riecoind_16.3_openssl_1.1.patch:112: trailing whitespace.
            // Since the minimum signed integer cannot be represented as positive so long as its type is signed, 
error: corrupt patch at line 586
Git cloned the latest code yesterday.
rieMiner - Riecoin solo + pooled miner
Personal Riecoin page (links, download,...)
freebitco.in - earn up to $200 in BTC each hour!

IGJ
Posts: 46
Joined: 21 Aug 2018, 11:43

Re: 0.16 wallet and bounty news??

Post by IGJ » 06 Oct 2018, 16:51

Fixed, try again but you have to clone the git, I guess part of the patch is applied even that error.

Since couple of hours revisiting the patch and found two misses I also fixed them in this version.

Pttn
Posts: 131
Joined: 24 Aug 2018, 13:37

Re: 0.16 wallet and bounty news??

Post by Pttn » 06 Oct 2018, 17:43

Ok, so now:
  • Can compile with OpenSsl 1.1 in Debien 9 Stretch, seems to work fine;
  • Can compile with OpenSsl 1.1 in Debien 9 Sid, but executable does absolutely nothing when started (stays started, no shutdown);
  • Cannot compile with OpenSsl 1.0 in Debien 9 Sid, with the EVP_MD_CTX_new error
rieMiner - Riecoin solo + pooled miner
Personal Riecoin page (links, download,...)
freebitco.in - earn up to $200 in BTC each hour!

IGJ
Posts: 46
Joined: 21 Aug 2018, 11:43

Re: 0.16 wallet and bounty news??

Post by IGJ » 07 Oct 2018, 23:46

Pttn wrote:
06 Oct 2018, 17:43
Ok, so now:
Can compile with OpenSsl 1.1 in Debien 9 Stretch, seems to work fine;
Very good seems the patch working then :)
Pttn wrote:
06 Oct 2018, 17:43
Can compile with OpenSsl 1.1 in Debien 9 Sid, but executable does absolutely nothing when started (stays started, no shutdown);
Cannot compile with OpenSsl 1.0 in Debien 9 Sid, with the EVP_MD_CTX_new error
Try now I made some changes.
For openssl 1.1 and up the function is called EVP_MD_CTX_new() / EVP_MD_CTX_free() which is what come from git (strange and fooled me) for openssl versions below is EVP_MD_CTX_create() / EVP_MD_CTX_destroy(). Eventually you can comment HAVE_DECL_EVP_MD_CTX_NEW checks insrc/qt/paymentrequestplus.cpp , because even from openssl 0.9.8+ these functions are present and should be used. Stack allocation of EVP_MD_CTX is not recommended by the documentation and is removed in 1.1 and up.

I will install in VM debian sid and will test but guess there is something else that make the binary do nothing. I tested now on debian 9 with openssl 1.1 and all working ok on first look, wallet connected to the network getting headers, and qt is showing. Did not test on debian 9 with openssl 1.0 but I guess it should work because then the original code (what come from git) is applied during compilation. Is there something in debug.log ?

Post Reply